feat: Search highlighting for Collectives #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
added
enhancement
Closed
2 failed and 2 flaky tests on run #1739 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Pages > Creating a page from template > New page has template content |
Screenshots
|
|
page-list.spec.js • 1 failed test • Nextcloud master
| Test | Artifacts | |
|---|---|---|
| Page list > Page trash > allows to trash and restore page with subpage and attachment |
Screenshots
|
|
cypress/e2e/collective-settings.spec.js • 2 flaky tests • Nextcloud stable27
Review all test suite changes for PR #1368 ↗︎
This comment was marked as resolved.
This comment was marked as resolved.
jancborchardt
previously requested changes
Jul 23, 2024
There was a problem hiding this comment.
Nice! Only additional feedback in addition to @nimishavijay’s is:
- The elements in the left navigation directly below the search field jump around vertically a little bit. It would be nice if they stay in place, e.g. the main Collective page.
Let's file that into a separate issue. Unrelated to this part of the implementation |
elzody
force-pushed
the
feat/search-highlighting
branch
from
6313954
to
20c39fc
Compare
AndyScherzinger
approved these changes
Jul 23, 2024
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
mejo-
force-pushed
the
feat/search-highlighting
branch
from
20c39fc
to
2154ee4
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
* Consolidate vuex search module * Get rid of watcher + duplicated state around `matchAll`/`highlightAll` * Scroll current search result into view Signed-off-by: Jonas <[email protected]>
mejo-
force-pushed
the
feat/search-highlighting
branch
from
2154ee4
to
02fb6d2
Compare
mejo-
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This pull request integrates search highlighting from the text app into collectives.
🖼️ Video
search_highlighting_example1.mp4
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)